extend filter parameters and fix issues#73
Open
Jon007 wants to merge 15 commits intomagicstickuk:masterfrom
Open
extend filter parameters and fix issues#73Jon007 wants to merge 15 commits intomagicstickuk:masterfrom
Jon007 wants to merge 15 commits intomagicstickuk:masterfrom
Conversation
and, bail if post can't be found, which happens if current blog not correctly restored
Add source blog id and filter to terms creation code to allow extension
- correct blog switching to get right links for admin messages - correct handling of wp error returned from wp_insert_term
plugins activated on source site may be triggered on target site when not applicable. Many plugins notice and suppress their save hooks if DOING_AUTOSAVE is set so this can be used to suppress: this is a background save not a foreground save of the displayed item in the displayed blog...
when termid fails creation because it already exists, the existing termid can be returned
some plugins have wizards which don't set any global current screen so get_current_screen() returns null
michaelw85
reviewed
Feb 26, 2021
| function change_tax_terms_table(){ | ||
|
|
||
| $options = get_option( 'mdp_settings' ); | ||
| if ( isset( $options[ 'master_site_setting' ] ) ) { |
There was a problem hiding this comment.
This fix is not sufficient. The $master_id var can be undefined within the if statement below due to this change.
If statement should also check if the var exists or a better solution in my opinion is to set the var with a null value and check if there is a value in the if statement.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
implements #72 with filter and additional parameters on terms
implements #65 with additional filter parameters, also permitting implementation of #63 to create persist post from within bulk copy, also permitting implementation of #61, #60, #59
fixes #69 by avoiding copy again to target blog: useful when called from bulk copy where easy to accidentally include some posts already copied
fixes #68
fixes #67
fixes #66
fixes #64