Skip to content

better default for handling transparency #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cpheinrich wants to merge 1 commit into
base: master
Choose a base branch
from
Open

better default for handling transparency #45

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions Source/Common/GLTFUnarchiver.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1050,8 +1050,6 @@ public class GLTFUnarchiver {
material.blendMode = .replace
case "BLEND":
material.blendMode = .alpha
material.writesToDepthBuffer = false
material.shaderModifiers![.surface] = try! String(contentsOf: URL(fileURLWithPath: Bundle(for: GLTFUnarchiver.self).path(forResource: "GLTFShaderModifierSurface_alphaModeBlend", ofType: "shader")!), encoding: String.Encoding.utf8)
case "MASK":
material.shaderModifiers![.fragment] = try! String(contentsOf: URL(fileURLWithPath: Bundle(for: GLTFUnarchiver.self).path(forResource: "GLTFShaderModifierFragment_alphaCutoff", ofType: "shader")!), encoding: String.Encoding.utf8)
default:
Expand Down
2 changes: 1 addition & 1 deletion Source/Common/schema/GLTFMaterial.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ struct GLTFMaterial: GLTFPropertyProtocol {
let _alphaMode: String?
/** The material's alpha rendering mode enumeration specifying the interpretation of the alpha value of the main factor and texture. */
var alphaMode: String {
get { return self._alphaMode ?? "OPAQUE" }
get { return self._alphaMode ?? "BLEND" }
}

let _alphaCutoff: Float?
Expand Down