add readme for fixed jsfooterplugin #89
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krzksz
reviewed
Mar 6, 2021
| 2. If you are using Magento 2.3.5 or lower, you need to have `mixins.js` module patched [(patch provided and explained here)](https://github.com/magento/baler/issues/23). | ||
| 3. If you are using Magento 2.3.3 or lower, you need `jquery.cookie` module shim [(patch provided and explained here)](https://github.com/magento/baler/issues/6). | ||
| 4. [Magepack Magento module](https://github.com/magesuite/magepack-magento) installed. | ||
| 4. If you are using Magento 2.3.6-p1 or lower, you need `JSFooterPlugin` patched [(patch provided and explained here)](https://github.com/magento/magento2/pull/27270). |
Collaborator
There was a problem hiding this comment.
Hey, thanks for contribution!
As far as I know this patch is not required for shorter pages but it is useful information nonetheless. Maybe we could change the wording that it is recommended to have this plugin patched?
krzksz
requested changes
Mar 6, 2021
Collaborator
krzksz
left a comment
krzksz
left a comment
There was a problem hiding this comment.
Please see the comment I added.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To be able to use "Move script to bottom" the mentioned patch should be installed.