Skip to content
This repository was archived by the owner on Dec 12, 2023. It is now read-only.

Integration tests for issue #1#2

Open
dodtsair wants to merge 1 commit intomaestrodev:masterfrom
dodtsair:master
Open

Integration tests for issue #1#2
dodtsair wants to merge 1 commit intomaestrodev:masterfrom
dodtsair:master

Conversation

@dodtsair
Copy link

@dodtsair dodtsair commented Mar 8, 2013

https://github.com/maestrodev/puppet-jenkins/issues/1

Setups up the tests plugin.pp with a vagrant file. Adds an exec invocation which checks to make sure that ~jenkins equals /var/lib/jenkins.

Note if you uncomment the init.pp test the problem goes away.

I initially intended to send you a fix for the problem. But I couldn't decide what the best approach was.

  1. jenkins:plugin already depends on jenkins, move user create to jenkins and configure its home directory correctly
  2. Configure home directory correctly in jenkins::plugin
  3. If the user doesn't exist then there will be far greater problems, no need to try and create the user. Delete the lines and let the rpm init scripts suffice.

@brettporter
Copy link
Contributor

Option 3 looks like the right solution to me - it probably just means that the right requirements are in place so that the package is installed before the user is needed. Happy to merge if you submit a fix.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants