-
-
Notifications
You must be signed in to change notification settings - Fork 200
Wrap toolbar items with MacosToolbarPassthrough #579
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@Adrian-Samoticha / @GroovinChip failing checks seem unrelated to this PR. |
Yeah, I believe we’ve been failing them for a while now. Thanks for the PR; we’ll review it soon! |
GroovinChip
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me, but there's some housekeeping that needs to happen on main before it can be merged. I'll try to get to in on Monday.
|
@cbenhagen In the meantime, could you please post a screenshot or gif of the change in action? Thanks. |
|
Hard to show in a gif. Without this change the window will maximize if you double click a toolbar item. |
|
@cbenhagen housekeeping has been completed. Please merge the latest changes from |
e5d1bb3 to
eeda9b5
Compare
|
@GroovinChip done ;) |
GroovinChip
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, but could you please write a test that validates the change so that we can minimize potential regression? Thanks!
|
Do you have a good idea how we could test that? |
|
@GroovinChip I mean we can just test if we find the |
|
@GroovinChip added some tests in 63777d4. |
GroovinChip
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Wrap toolbar items with
MacosToolbarPassthroughto prevent window move or resize when interacting with toolbar items.Pre-launch Checklist
CHANGELOG.mdwith my changes