Fixes to recording #1808
Merged
Fixes to recording #1808
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
March 9, 2022 11:43
lodoyun
reviewed
Mar 16, 2022
Contributor
lodoyun
left a comment
lodoyun
left a comment
There was a problem hiding this comment.
In general I think this looks good. I do have a question that I feel would avoid adding new methods to set the hasVideo and hasAudio flags when we already have that info when the object is created
| const externalOutput = new erizo.ExternalOutput(this.threadPool, url, | ||
| Helpers.getMediaConfiguration(options.mediaConfiguration)); | ||
| externalOutput.id = eoId; | ||
| externalOutput.setHasAudioAndVideo(hasAudio, hasVideo); |
Contributor
There was a problem hiding this comment.
Why not just pass hasAudio and hasVideo in the constructor just like we do for MediaStream?
Contributor
Author
There was a problem hiding this comment.
Makes sense, I will update it
lodoyun
approved these changes
Mar 25, 2022
Contributor
lodoyun
left a comment
lodoyun
left a comment
There was a problem hiding this comment.
Looks good to me 👍 but please fix the log level as indicated in the comment
Thanks!
|
|
||
| log4j.logger.media.ExternalInput=WARN | ||
| log4j.logger.media.ExternalOutput=WARN | ||
| log4j.logger.media.ExternalOutput=DEBUG |
Contributor
There was a problem hiding this comment.
consider making this WARN again
Contributor
|
Thanks @Arri98 for giving credit and for your contribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixed some issues with recording:
Also removed the toggleRecording button in the basic example and changed it for individual buttons so the user can select the stream to record.
[] It needs and includes Unit Tests
Changes in Client or Server public APIs
No changes
[] It includes documentation for these changes in
/doc.No changes