Added private property #counter to allow internal edits with Object.freez()#41
Open
ahelmi365 wants to merge 1 commit intolydiahallie:mainfrom
Open
Added private property #counter to allow internal edits with Object.freez()#41ahelmi365 wants to merge 1 commit intolydiahallie:mainfrom
ahelmi365 wants to merge 1 commit intolydiahallie:mainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For data properties of a frozen object, their values cannot be changed since the
writableandconfigurableattributes are set tofalse.If we try to use the
increment()ordecrement()methods withObject.freez(), we get a TypeError says :Cannot assign to read only property 'counter' of object '#<Counter>' at Counter.increment"Private properties do not have the concept of property descriptors. Freezing an object with private properties does not prevent the values of these private properties from being changed.
In my request, I've added the
#counterproperty as private property. Now we can use theincrement()anddecrement()methods withObject.freez()with no errors.