Change singleton pattern counter class#29
Open
bpetermann wants to merge 1 commit intolydiahallie:mainfrom
Open
Change singleton pattern counter class#29bpetermann wants to merge 1 commit intolydiahallie:mainfrom
bpetermann wants to merge 1 commit intolydiahallie:mainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
the counter class gave me the following error messages:
Removing Object.freeze and returning the instance in the constructor should resolve this issue.
Otherwise, as in the Objects example, counter can also be initiated outside the class: let counter = 0;
After that, however, the "this" keyword would have to be removed from the methods.
Thanks!