Add entry and exit reactions to pystate#1
Open
TobiasPleyer wants to merge 1 commit intolwanger:masterfrom
Open
Add entry and exit reactions to pystate#1TobiasPleyer wants to merge 1 commit intolwanger:masterfrom
TobiasPleyer wants to merge 1 commit intolwanger:masterfrom
Conversation
Entry and exit reactions are very useful if there are certain things
that have to be done every time we enter or leave a state (e.g.
cleanup). Instead of making sure that every handler performs the correct
tasks this will be handled by the function `transition_to`.
This is less error prone, more intuitive and saves key strokes.
Changes
* The State class has 4 new methods:
- add entry_reaction
- remove entry_reaction
- add exit_reaction
- remove exit_reaction
* In addition to changing the variable current_state the function
`transition_to` does:
- Call the exit reactions of the old state
- Call the entry reactions of the new state
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Entry and exit reactions are very useful if there are certain things
that have to be done every time we enter or leave a state (e.g.
cleanup). Instead of making sure that every handler performs the correct
tasks this will be handled by the function
transition_to.This is less error prone, more intuitive and saves key strokes.
Changes
* The State class has 4 new methods:
- add entry_reaction
- remove entry_reaction
- add exit_reaction
- remove exit_reaction
* In addition to changing the variable current_state the function
transition_todoes:- Call the exit reactions of the old state
- Call the entry reactions of the new state