Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Albumentations engine reads data["bboxes"], so augmentations that read bounding boxes (in this example this concerned
AtLeastOneBBoxRandomCrop) would not actually resort to the bounding boxes.Specification
Dependencies & Potential Impact
Deployment Plan
Testing & Validation
Before this fix, using the following config on inspecting the crack instance segmentation dataset:
Would lead to some images with crops not actually containing bounding boxes, even though this augmentation should guarantee a bounding box per image crop. For example:
With this fix, even with a small crop size (40x40), every resulting image contains a bounding box: