Skip to content

Changes to parsing behavior, documentation and tests#391

Merged
dtronmans merged 6 commits intomainfrom
feat/coco-2017-keypoints
Feb 24, 2026
Merged

Changes to parsing behavior, documentation and tests#391
dtronmans merged 6 commits intomainfrom
feat/coco-2017-keypoints

Conversation

@dtronmans
Copy link
Contributor

Purpose

  • Allow keypoint annotations parsing for COCO using the use_keypoint_ann when test annotation json is
  • Revert previous change: previously I allowed all images to contain hard negatives (no ground truth labels) for dense estimation tasks (instance segmentation, detection and keypoints). Now just for coco-2017 keypoints we don't parse these images with no annotations, because over 50% of the images in the dataset don't have keypoints
  • Documentation regarding parsing coco-2017 and imagenet-sample to make everything clearer
  • Test structure and first few tests for parsing using CLI, we can add more over time depending on edge cases that appear or behavior we want to enforce.
  • Added coco keypoints to test_parse_export_equivalence and added equivalency testing for semantic segmentation masks (realized I had it for instance segmentation but not semantic segmentation)

Specification

Dependencies & Potential Impact

Deployment Plan

Testing & Validation

@dtronmans dtronmans requested a review from a team as a code owner February 18, 2026 08:35
@dtronmans dtronmans requested review from conorsim, klemen1999, kozlov721 and tersekmatija and removed request for a team February 18, 2026 08:35
@github-actions github-actions bot added documentation Improvements or additions to documentation enhancement New feature or request tests Adding or changing tests labels Feb 18, 2026
@dtronmans dtronmans requested a review from ptoupas February 18, 2026 08:36
Copy link
Collaborator

@klemen1999 klemen1999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small nitpick but overall LGTM

Copy link

@ptoupas ptoupas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a couple of minor comments, but apart from that it LGTM.

@dtronmans dtronmans merged commit cb4e0d5 into main Feb 24, 2026
13 checks passed
@dtronmans dtronmans deleted the feat/coco-2017-keypoints branch February 24, 2026 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation enhancement New feature or request tests Adding or changing tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants