Removed deprecated parameters from make_splits#247
Open
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #247 +/- ##
==========================================
+ Coverage 96.03% 96.08% +0.05%
==========================================
Files 94 94
Lines 5064 5057 -7
==========================================
- Hits 4863 4859 -4
+ Misses 201 198 -3 ☔ View full report in Codecov by Sentry. |
kozlov721
requested review from
conorsim,
klemen1999 and
tersekmatija
and removed request for
a team
klemen1999
reviewed
Feb 17, 2025
| new_splits = self._make_definition_splits(splits) # type: ignore | ||
|
|
||
| for split, uuids in new_splits.items(): | ||
| old_splits[split].extend(uuids) |
Collaborator
There was a problem hiding this comment.
We should only extend if replace_old_splits=False no? Otherwise if split_type="files" wouldn't we in this case now get one image in two times in the splits (once from older split and once from newer one)?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Simplifies the creation of splits.
Specification
definitionsandratiosfromBaseDataset.make_splitsLuxonisDataset.make_splitsDependencies & Potential Impact
Breaking change by removing parameters from
make_splitsthat have been mark as deprecated for the last 2 releases.