Skip to content

Comments

ExtendedNeuralNetwork node#249

Closed
tadeas0 wants to merge 22 commits intomainfrom
feat/stage-1-node
Closed

ExtendedNeuralNetwork node#249
tadeas0 wants to merge 22 commits intomainfrom
feat/stage-1-node

Conversation

@tadeas0
Copy link
Contributor

@tadeas0 tadeas0 commented Oct 24, 2025

Purpose

Create ExtendedNeuralNetwork node that wraps ParsingNeuralNetwork and adds the following capabilities:

  • Automatic input resizing to the neural network input size
  • Remapping of detection coordinates from neural network output to input frame coordinates
  • Neural network output filtering based on confidence threshold and labels (Only supported for ImgDetectionsExtended and ImgDetections messages)
  • Input tiling

Specification

https://app.clickup.com/t/86c5mz8er

Dependencies & Potential Impact

None / not applicable

Deployment Plan

None / not applicable

Testing & Validation

Manually tested on RVC4. Currently does not work on RVC2 due to missing transformation bindings in DAI Script node.

Example usage

extended_neural_network_example.py

Copy link
Contributor

@aljazkonec1 aljazkonec1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Took a quick look and left some comments. Mostly looks good, just a couple of minor fixes. Thanks!

Should we add tests aswell?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

General comment for entire PR: Use logger to log the stages of the class. Something like logger.info("Building TilingPipeline") and logger.info("Building Tiles patcher") etc etc.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree, check the parsers implementation for reference.

@tadeas0
Copy link
Contributor Author

tadeas0 commented Oct 29, 2025

Should we add tests aswell?

Unit tests would require mocking Script and ImageManip nodes. We can add integration tests, however, I would create a separate PR for those to get this merged ASAP, because it's blocking Stage2NeuralNetwork node PR.

@tadeas0 tadeas0 requested a review from aljazkonec1 October 29, 2025 13:12
@PetrNovota
Copy link
Contributor

@tadeas0 FYI I am testing the new 1st and 2nd stage nodes in the focused vision PoC and have encountered an issue so we will likely not be merging either PR very quickly. I will let you know what the issue is.

@klemen1999
Copy link
Collaborator

Closing as this was re-implemented in #274

@klemen1999 klemen1999 closed this Jan 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants