Conversation
aljazkonec1
left a comment
There was a problem hiding this comment.
Took a quick look and left some comments. Mostly looks good, just a couple of minor fixes. Thanks!
Should we add tests aswell?
There was a problem hiding this comment.
General comment for entire PR: Use logger to log the stages of the class. Something like logger.info("Building TilingPipeline") and logger.info("Building Tiles patcher") etc etc.
There was a problem hiding this comment.
Agree, check the parsers implementation for reference.
Unit tests would require mocking |
|
@tadeas0 FYI I am testing the new 1st and 2nd stage nodes in the focused vision PoC and have encountered an issue so we will likely not be merging either PR very quickly. I will let you know what the issue is. |
|
Closing as this was re-implemented in #274 |
Purpose
Create
ExtendedNeuralNetworknode that wrapsParsingNeuralNetworkand adds the following capabilities:ImgDetectionsExtendedandImgDetectionsmessages)Specification
https://app.clickup.com/t/86c5mz8er
Dependencies & Potential Impact
None / not applicable
Deployment Plan
None / not applicable
Testing & Validation
Manually tested on RVC4. Currently does not work on RVC2 due to missing transformation bindings in DAI
Scriptnode.Example usage
extended_neural_network_example.py