Make fnTest not match _super in line comments#49
Open
JelteF wants to merge 1 commit intolukasolson:masterfrom
Open
Make fnTest not match _super in line comments#49JelteF wants to merge 1 commit intolukasolson:masterfrom
JelteF wants to merge 1 commit intolukasolson:masterfrom
Conversation
Multiline comments are much harder to distinguish with a regex. This is probably an indication that the current method of testing wether super is used in a method is not very good. Maybe another method needs to be found.
Collaborator
|
Can you add tests for this? |
Author
|
I'm not sure how testing works in javascript, but it should not match against strings like these: And it should match against |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Multiline comments are much harder to distinguish with a regex. This is probably an indication that the current method of testing wether super is used in a method is not very good. Maybe another method needs to be found.