Rename EXTERN_C Macros that have reserved names #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… interferes with Standard Library headers in MSVC
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use of the Macro _END_EXTERN_C interferes with Standard Library headers in MSVC. This PR renames _END_EXTERN_C and _BEGIN_EXTERN_C so they do not have reserved names starting with an underscore and Uppercase letter.
The use of _END_EXTERN_C was causing me trouble when getopt,h was included between 2 different standard library includes. The standard library headers had defined it before getopt.h was included, and getopt.h undefines it causing the following standard library includes to fail.
I didn't rename any of the other Macros that have reseved names starting with an underscore as they didn't seem like they would cause trouble.