Supporting different javascript runtime options. npm, yarn, and bun. #889
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This changes the app generator to ask for the javascript runtime if the options if `full`. Lucky doesn't really need to know about this as long as it gets the manifest file it's seeking.
russ
added a commit
to russ/lucky
that referenced
this pull request
Jun 17, 2025
This is in tandem with luckyframework/lucky_cli#889 I'm not a huge fan of how this part has to be done. I would love a different approach.
Closed
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the app generator to ask for the javascript runtime if the options if
full. Lucky doesn't really need to know about this as long as it gets the manifest file it's seeking.I'm sure I've probably messed something up here and I need some more eyes on this.