Migrate to Bzlmod #47
Conversation
MODULE.bazel
Outdated
| bazel_dep(name = "rules_jvm_external", version = "6.4") | ||
| bazel_dep(name = "rules_scala_annex") | ||
|
|
||
| rules_scala_annex_version = "bzlmod-migration" |
There was a problem hiding this comment.
- Wait until we've merged Migrate to Bzlmod rules_scala#74 and update this.
jjudd
left a comment
jjudd
left a comment
There was a problem hiding this comment.
Mostly LGTM. Left a few comments.
MODULE.bazel
Outdated
| module(name = "rules_twirl") | ||
|
|
||
| bazel_dep(name = "bazel_skylib", version = "1.7.1") | ||
| bazel_dep(name = "buildifier_prebuilt", version = "7.3.1") |
There was a problem hiding this comment.
I think we can mark this as dev_dependency
There was a problem hiding this comment.
See my comment here:
lucidsoftware/rules_scala#74 (comment)
MODULE.bazel
Outdated
| bazel_dep(name = "bazel_skylib", version = "1.7.1") | ||
| bazel_dep(name = "buildifier_prebuilt", version = "7.3.1") | ||
| bazel_dep(name = "rules_java", version = "7.11.1") | ||
| bazel_dep(name = "rules_pkg", version = "1.0.1") |
There was a problem hiding this comment.
I think we can mark this as dev_dependency
There was a problem hiding this comment.
See my comment here:
lucidsoftware/rules_scala#74 (comment)
MODULE.bazel
Outdated
| urls = ["https://github.com/lucidsoftware/rules_scala/archive/refs/heads/{}.zip".format(rules_scala_annex_version)], | ||
| ) | ||
|
|
||
| bazel_dep(name = "stardoc", version = "0.7.1") |
There was a problem hiding this comment.
Can this be moved up with the other bazel_deps?
Also I think we can mark this as dev_dependency
There was a problem hiding this comment.
See my comment here:
lucidsoftware/rules_play_routes#57 (comment)
MODULE.bazel
Outdated
|
|
||
| specs2_version = "4.20.8" | ||
|
|
||
| zinc_version = "1.10.1" |
There was a problem hiding this comment.
Scope creep, but can we please update this to 1.10.4? Annex is already on that version, so it should be as simple as changing the version and updating the lockfile.
jadenPete
force-pushed
the
bzlmod-migration
branch
from
d1f4321 to
20610a7
Compare
|
Squashed. |
No description provided.