Provide a streaming result set #64
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow users who want access to an underlying result set that is large to do so through use of streamed statements
tmccombs
reviewed
May 8, 2018
Contributor
tmccombs
left a comment
tmccombs
left a comment
There was a problem hiding this comment.
I'm fine with this. But what is the usecase where the asIterator method isn't sufficient?
| * This allows for interacting with large data sets with less risk of OutOfMemoryErrors. | ||
| * Many JDBC connectors will not allow for additional queries to the connection until the | ||
| * returned ResultSet has been closed. | ||
| * @param fetchSize the number of rows to fetch at a time, defaults to 100. If the JDBC Driver |
Contributor
There was a problem hiding this comment.
Where does this default come from? It seems like the fetchSize is required here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow users who want access to an underlying result set that is large to
do so through use of streamed statements