Improve error logging when piezo admin sync fails due to null key value #127
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tnnrj
approved these changes
Dec 17, 2025
tnnrj
reviewed
Dec 17, 2025
| jobData.getKeys.foldLeft(List[DataMap]())((sofar, key) => { | ||
| val value = jobData.get(key) | ||
| if (value == null) { | ||
| throw new NullPointerException( |
Contributor
There was a problem hiding this comment.
Could we just log a message and ignore null values instead for stability?
Contributor
Author
There was a problem hiding this comment.
Maybe, but I worry about that getting us into an unintended state. I'd like to understand what caused this error first, before deciding the best way to handle it moving forward.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Log the job name and key name when a datamap key fails due to a null value.