-
Notifications
You must be signed in to change notification settings - Fork 5
RDS module, fixes #150 #154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
lib/rds/manager/Manager.rb
Outdated
| aws_instance = RDS::named_instances[local.name] | ||
| client = Aws::RDS::Client.new(Configuration.instance.client) | ||
|
|
||
| modify_instance = Proc.new do |options_hash| |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there any way to batch these up so we don't make a bunch of calls if we decide to change several attributes at once?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good idea. I'll do that. should be simple.
|
You should add some tests like I did in the SQS module. That would be super rad. Also... add documentation for it on the |
|
@msiebert jerk! |
|
uhh. wow. all I wanted was to push a few testing-related commits. seems like it pushed a lot more. |
|
dude, @mcrossen, I'm loving the fact that there are tests here! Way to go! |
|
yea. me too! |
db subnet groups will need to be managed differently (like how ec2 instances are managed different from ebs). For now, db subnet groups can be managed in the aws console. Apart from that everything seems to be working.