Skip to content

Conversation

@mcrossen
Copy link
Contributor

@mcrossen mcrossen commented Aug 5, 2016

db subnet groups will need to be managed differently (like how ec2 instances are managed different from ebs). For now, db subnet groups can be managed in the aws console. Apart from that everything seems to be working.

@mcrossen mcrossen changed the title RDS module RDS module, fixes #154 Aug 5, 2016
@mcrossen mcrossen changed the title RDS module, fixes #154 RDS module, fixes #150 Aug 5, 2016
aws_instance = RDS::named_instances[local.name]
client = Aws::RDS::Client.new(Configuration.instance.client)

modify_instance = Proc.new do |options_hash|
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any way to batch these up so we don't make a bunch of calls if we decide to change several attributes at once?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good idea. I'll do that. should be simple.

@msiebert
Copy link
Contributor

msiebert commented Aug 8, 2016

You should add some tests like I did in the SQS module. That would be super rad. Also... add documentation for it on the gh-pages branch. Man, I'm so glad I can make your life terrible even after leaving.

@mcrossen
Copy link
Contributor Author

mcrossen commented Aug 9, 2016

@msiebert jerk!
ok. good idea. i've already made the documentation, but wasn't going to make a pull request for it until this is merged. I guess I can at least push it.

@mcrossen mcrossen self-assigned this Aug 13, 2016
@mcrossen mcrossen added the rds label Aug 15, 2016
@mcrossen
Copy link
Contributor Author

mcrossen commented Aug 16, 2016

uhh. wow. all I wanted was to push a few testing-related commits. seems like it pushed a lot more.
well.... uhh.... oops
I'm going to fix that and force push it all out.

@msiebert
Copy link
Contributor

dude, @mcrossen, I'm loving the fact that there are tests here! Way to go!

@mcrossen
Copy link
Contributor Author

yea. me too!
so this pull request is ready to be reviewed again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants