DM-54164: Switch uname from p to m to fix a linux x86 bug#350
Conversation
| || fail "Unable to determine conda env" | ||
| platform="$(uname -s)" | ||
| arch="$(uname -p)" | ||
| arch="$(uname -m)" |
There was a problem hiding this comment.
Does this mean that the check against $arch below in the Darwin section needs to be arm64 instead of arm?
There was a problem hiding this comment.
On my mac, it still worked, but I think switching to arm64 is a better idea.
There was a problem hiding this comment.
$ uname -p
arm
$ uname -m
arm64
so not at all clear how this would have passed the test below which was looking for arm.
roceb
force-pushed
the
tickets/DM-54164
branch
from
451fb1f to
a869201
Compare
timj
left a comment
timj
left a comment
There was a problem hiding this comment.
I guess this is fine but I have no idea what the motivation is for doing any of it.
-p and -m make no difference on x86_64. Please justify the change in the commit message and on the jira ticket.
| || fail "Unable to determine conda env" | ||
| platform="$(uname -s)" | ||
| arch="$(uname -p)" | ||
| arch="$(uname -m)" |
There was a problem hiding this comment.
$ uname -p
arm
$ uname -m
arm64
so not at all clear how this would have passed the test below which was looking for arm.
v30_0_0.env
Outdated
| @@ -0,0 +1,797 @@ | |||
| # This file may be used to create an environment using: | |||
There was a problem hiding this comment.
Yes, I was testing with it.
roceb
force-pushed
the
tickets/DM-54164
branch
2 times, most recently
from
ad5b9d7 to
8e5047b
Compare
uname -p would report as unknown on some linux x86 machines
roceb
force-pushed
the
tickets/DM-54164
branch
from
8e5047b to
dd942f8
Compare
roceb
changed the title
2 participants
No description provided.