DM-53940: Add convertCentroid for X/Y to RA/dec covariance #818
+88
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taranu
force-pushed
the
tickets/DM-53940
branch
2 times, most recently
from
0ccca3b to
0238058
Compare
taranu
force-pushed
the
tickets/DM-53940
branch
from
0238058 to
382046b
Compare
cmsaunders
approved these changes
Jan 30, 2026
Contributor
cmsaunders
left a comment
cmsaunders
left a comment
There was a problem hiding this comment.
LGTM. I can't actually remember why calculateCoordCovariance returns radians...
Contributor
Author
It's because it's made primarily for SourceCatalogs which have centroids in radians, ostensibly for better precision. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.