Skip to content

Odim 6412 :added method not allowed for unallowed http operation #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lpooja wants to merge 5 commits into
base: sprint59_odim6412
Choose a base branch
from
Open

Odim 6412 :added method not allowed for unallowed http operation #34

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
0af8279
added method not allowed
lpooja Aug 10, 2022
eced61c
removed logs
lpooja Aug 16, 2022
4845030
remove delted file
lpooja Aug 16, 2022
c6ed1e4
added logs
lpooja Aug 18, 2022
3c0c7db
resolving conflictd
lpooja Aug 18, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions svc-api/handle/handlers.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1241,6 +1241,12 @@ func UpdateServiceMethodNotAllowed(ctx iris.Context) {
fillMethodNotAllowedErrorResponse(ctx)
return
}
func MethodNotAllowed(ctx iris.Context) {
defer ctx.Next()
ctx.ResponseWriter().Header().Set("Allow", "GET")
fillMethodNotAllowedErrorResponse(ctx)
return
}

// ChassisMethodNotAllowed holds builds reponse for the unallowed http operation on Chassis URLs and returns 405 error.
func ChassisMethodNotAllowed(ctx iris.Context) {
Expand Down
12 changes: 10 additions & 2 deletions svc-api/router/router.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -195,7 +195,7 @@ func Router() *iris.Application {
serviceRoot := handle.InitServiceRoot()

router := iris.New()

router.OnErrorCode(iris.StatusNotFound, handle.SystemsMethodInvalidURI)
var reqBody map[string]interface{}
// Parses the URL and performs URL decoding for path
// Getting the request body copy
Expand Down Expand Up @@ -680,6 +680,14 @@ func Router() *iris.Application {
telemetryService.Get("/MetricReports/{id}", telemetry.GetMetricReport)
telemetryService.Get("/Triggers/{id}", telemetry.GetTrigger)
telemetryService.Patch("/Triggers/{id}", telemetry.UpdateTrigger)
telemetryService.Any("/MetricDefinitions", handle.MethodNotAllowed)
telemetryService.Any("/MetricReportDefinitions", handle.MethodNotAllowed)
telemetryService.Any("/MetricReports", handle.MethodNotAllowed)
telemetryService.Any("/Triggers", handle.MethodNotAllowed)
telemetryService.Any("/MetricDefinitions/{id}", handle.MethodNotAllowed)
telemetryService.Any("/MetricReportDefinitions/{id}", handle.MethodNotAllowed)
telemetryService.Any("/MetricReports/{id}", handle.MethodNotAllowed)
telemetryService.Any("/Triggers/{id}", handle.MethodNotAllowed)

licenseService := v1.Party("/LicenseService", middleware.SessionDelMiddleware)
licenseService.SetRegisterRule(iris.RouteSkip)
Expand Down Expand Up @@ -715,4 +723,4 @@ func Router() *iris.Application {
compositionService.Any("/FreePool", handle.CompositionServiceMethodNotAllowed)
compositionService.Any("/ActivePool", handle.CompositionServiceMethodNotAllowed)
return router
}
}