Make a proper Python project #7
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows the Python code to be installed with pip install or similar tools, along with dependencies (freetype-py and Pillow). It also installs afinate as a script in the python environment.
Author
|
Also includes some random whitespace removal from end of lines. It may make sense just to run Black on the Python code, but whether that's part of this PR is another question. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows the Python code to be installed with
pipinstall or similar tools, along with dependencies (freetype-py and Pillow). Additionally changes the scripts so that they don't need to do hacking ofsys.path: the idea being to install the package into a virtual environment and then run the scripts.Includes a couple of drive-by fixes to imports and one bad variable name that are needed to get the code working to test.