[pentest] Add ECC256 Keygen SCA test#22190
Closed
nasahlpa wants to merge 1 commit intolowRISC:earlgrey_es_sivalfrom
Closed
[pentest] Add ECC256 Keygen SCA test#22190nasahlpa wants to merge 1 commit intolowRISC:earlgrey_es_sivalfrom
nasahlpa wants to merge 1 commit intolowRISC:earlgrey_es_sivalfrom
Conversation
nasahlpa
added a commit
to nasahlpa/ot-sca
that referenced
this pull request
Mar 22, 2024
This commit enables communication with the OTBN SCA code over uJSON. The device code is located in lowRISC/opentitan#22190. Signed-off-by: Pascal Nasahl <nasahlpa@lowrisc.org>
nasahlpa
force-pushed
the
ujson_otbn_port
branch
2 times, most recently
from
a84e637 to
43310a0
Compare
nasahlpa
added a commit
to nasahlpa/ot-sca
that referenced
this pull request
Mar 22, 2024
This commit enables communication with the OTBN SCA code over uJSON. The device code is located in lowRISC/opentitan#22190. Signed-off-by: Pascal Nasahl <nasahlpa@lowrisc.org>
nasahlpa
added a commit
to nasahlpa/ot-sca
that referenced
this pull request
Mar 22, 2024
This commit enables communication with the OTBN SCA code over uJSON. The device code is located in lowRISC/opentitan#22190. Signed-off-by: Pascal Nasahl <nasahlpa@lowrisc.org>
nasahlpa
added a commit
to nasahlpa/ot-sca
that referenced
this pull request
Mar 22, 2024
This commit enables communication with the OTBN SCA code over uJSON. The device code is located in lowRISC/opentitan#22190. Signed-off-by: Pascal Nasahl <nasahlpa@lowrisc.org>
nasahlpa
force-pushed
the
ujson_otbn_port
branch
from
43310a0 to
c03d4fb
Compare
nasahlpa
added a commit
to nasahlpa/ot-sca
that referenced
this pull request
Mar 26, 2024
This commit enables communication with the OTBN SCA code over uJSON. The device code is located in lowRISC/opentitan#22190. Signed-off-by: Pascal Nasahl <nasahlpa@lowrisc.org>
nasahlpa
force-pushed
the
ujson_otbn_port
branch
from
c03d4fb to
bc7f117
Compare
nasahlpa
changed the title
nasahlpa
force-pushed
the
ujson_otbn_port
branch
from
bc7f117 to
dc34cd9
Compare
nasahlpa
requested review from
HU90m,
johannheyszl,
m-temp,
vogelpi and
wettermo
and removed request for
a team and
HU90m
nasahlpa
force-pushed
the
ujson_otbn_port
branch
from
dc34cd9 to
6f714a9
Compare
m-temp
reviewed
Apr 15, 2024
Contributor
m-temp
left a comment
m-temp
left a comment
There was a problem hiding this comment.
I had a look at the code.
LGTM, but I'm nor very familiar with writing device code.
| * | ||
| * Adds the integer stored in source array to the integer stored in | ||
| * destination aray. | ||
| * The user needs to ensure that dest_len isenough to store the result |
| * | ||
| * @param[in] dest Location of the first input array and the result. | ||
| * @param[in] source Location of the second input array. | ||
| * @param[in] dest_len Length od the dest array in bytes. |
nasahlpa
force-pushed
the
ujson_otbn_port
branch
4 times, most recently
from
282a821 to
b16e852
Compare
nasahlpa
added a commit
to nasahlpa/ot-sca
that referenced
this pull request
Apr 16, 2024
This commit enables communication with the OTBN SCA code over uJSON. Currently, the ECC256 Keygen SCA test is supported. The device code is located in lowRISC/opentitan#22190. Signed-off-by: Pascal Nasahl <nasahlpa@lowrisc.org>
nasahlpa
force-pushed
the
ujson_otbn_port
branch
from
b16e852 to
dcc0422
Compare
nasahlpa
added a commit
to nasahlpa/ot-sca
that referenced
this pull request
Apr 17, 2024
This commit enables communication with the OTBN SCA code over uJSON. Currently, the ECC256 Keygen SCA test is supported. The device code is located in lowRISC/opentitan#22190. Signed-off-by: Pascal Nasahl <nasahlpa@lowrisc.org>
nasahlpa
added a commit
to nasahlpa/ot-sca
that referenced
this pull request
Apr 17, 2024
This commit enables communication with the OTBN SCA code over uJSON. Currently, the ECC256 Keygen SCA test is supported. The device code is located in lowRISC/opentitan#22190. Signed-off-by: Pascal Nasahl <nasahlpa@lowrisc.org>
wettermo
reviewed
Apr 17, 2024
| kScaPeripheralEdn | kScaPeripheralHmac); | ||
|
|
||
| // Load p256 keygen from seed app into OTBN. | ||
| if (otbn_load_app(kOtbnAppP256KeyFromSeed).value != OTCRYPTO_OK.value) { |
Contributor
There was a problem hiding this comment.
I assume that this was already there in the previous version of the code, but do we need app loading here?
I mean it's done in handle_otbn_sca_ecc256_app_select anyway, and also in p256_run_keygen it's re-loaded for every iteration.
Of course it doesn't do any harm to load it anyway as default, but probably could be omitted here.
Member
Author
There was a problem hiding this comment.
Ah yeah, you are right. I've removed it :)
nasahlpa
force-pushed
the
ujson_otbn_port
branch
3 times, most recently
from
6d41106 to
78c57c5
Compare
nasahlpa
added a commit
to nasahlpa/ot-sca
that referenced
this pull request
Apr 18, 2024
This commit enables communication with the OTBN SCA code over uJSON. Currently, the ECC256 Keygen SCA test is supported. The device code is located in lowRISC/opentitan#22190. Signed-off-by: Pascal Nasahl <nasahlpa@lowrisc.org>
Member
Author
|
Currently not building as after a rebase the image size exceeds the available IMEM. This issue is resolved by #22717 |
nasahlpa
force-pushed
the
ujson_otbn_port
branch
from
78c57c5 to
2857e11
Compare
This commit adds the ECC256 key generation side-channel penetration test to the codebase. The host code is located in lowRISC/ot-sca#347 Signed-off-by: Pascal Nasahl <nasahlpa@lowrisc.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit adds the ECC256 key generation side-channel penetration test to the codebase.
The host code is located in lowRISC/ot-sca#347