Open
Conversation
moqmar
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change handles imports of existing entries correctly and thus solves #36: if the entry is the same (hostname, username and password), it gets skipped. If the password is different (but an entry with the same hostname & username already exists), a warning is issued, unless
--overwriteis specified, in which case the entry gets overwritten.During usual Firefox UI workflow, it's not possible to create an entry with
##in the hostname, which is the reason why I used that as the delimiter. Note that it is possible in Firefox's password manager UI to create two entries with the same username but different passwords, in which case only one of them will get overwritten.