WIP : Feat/notification push #89
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Code-Hello
commented
Apr 14, 2023
Code-Hello
commented
- add push notification using Novu FCM integration
- update pwa
✅ Deploy Preview for rolebase ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Godefroy
requested changes
Apr 15, 2023
Collaborator
Godefroy
left a comment
Godefroy
left a comment
There was a problem hiding this comment.
Ca a pas du être évident cette PR, GG 👏
La qualité des images que tu as rajoutées ne semble pas bonne. Je recommande pour cela de recréer des png à partir du svg. Pour cela une méthode simple est de modifier la taille (width & height) de icon.svg puis de le passer dans https://svgtopng.com/
J'ai l'impression que tu as laissé des images qui étaient utilisées dans l'ancien manifest et qui ne sont plus utilisées nulle part. Tu peux vérifier ?
D'ailleurs es-tu sûre qu'avec les images déjà présentes dans l'ancien manifest ça ne suffisait pas ?
Code-Hello
force-pushed
the
feat/notification-push
branch
from
aa3a5a7 to
ef616c6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.