Added windows support#78
Added windows support#78Mohammadsaknini wants to merge 2 commits intologic-and-learning-lab:mainfrom
Conversation
…threads instead of Signal
|
Tbh its been a while, but i do think it is indeed a typo. Probably forgot to remove it while fiddling around with the code. |
|
I've tested the code and it does work on Windows. Kudos for the fix, it really helped me. Thanks! 👍 |
|
Dear @Mohammadsaknini I applied your changes to util.py and still get this Attribute Error: module 'signal' has no attribute 'SIGALRM'. Did you mean: 'SIGABRT'? whenever I want to test the examples against Popper. I would be thankful for your help! |
This pull request was created a year ago, and I'm not sure if the codebase is still the same. However, according to Peterasa, there appears to be a similar timeout construct in loop.py, so it might be worth checking that. |
Singnal is only partially supported under windows, so i created the timeout function using threads instead of singals which should work on windows as an alternative.