Open
Conversation
timeout function, if given a bad timeout bound (zero or less), could run forever.
Collaborator
|
This issue is actually bigger than this commit. Popper is ignoring timeouts in other parts of the system. I have added it to my TODO list. |
Contributor
Author
Fair enough, but I think this one's worth merging for now, while more waits in the queue. We looked at putting timeouts on some of the subsidiary solvers, but it seemed very fussy, and we weren't confident in our understanding. And rightly not! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
popper.util.timeout()function, if given a bad timeout bound (zero or less), could run forever.