Skip to content

Support non-contiguous user ids and different groups per feature. #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
texel wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Support non-contiguous user ids and different groups per feature. #1

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
aaa88a7
Support non-contiguous user ids and different groups per feature.
Aug 17, 2014
392cf1e
Better, repeatable hashing.
Aug 17, 2014
d26f2d7
Nicer hash wrappers.
Aug 17, 2014
b522931
Use CRC32
Aug 18, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion lib/rollout.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
require 'zlib'

class Rollout

attr_accessor :redis, :groups
Expand Down Expand Up @@ -89,6 +91,14 @@ def user_within_active_percentage?(feature, user)
percentage = percentage(feature)
return false if percentage.nil?

user.id % 10 < percentage.to_i / 10
combined_hash(user.id, feature) % 100 < percentage.to_i
end

def combined_hash(*objects)
objects.inject(0) { |m,o| m + integer_hash(o) }
end

def integer_hash(obj)
Zlib.crc32 obj.to_s
end
end