Quick Fix for SubscripttonManagement servlet#6
Open
WilliamPetit wants to merge 1 commit intolockss:masterfrom
Open
Quick Fix for SubscripttonManagement servlet#6WilliamPetit wants to merge 1 commit intolockss:masterfrom
WilliamPetit wants to merge 1 commit intolockss:masterfrom
Conversation
The UpdateSubscriptions() function was considering a subsciption with missing status parameter as a 'subscription to update to unset'. It mainly because the getTriBoxValue function return the same thing whether the value of the parameter is 'null' or 'unset'. Therefore, this fix simply make sure the parameter wasn't 'null' before updating the subscription.
fergaloy
reviewed
Sep 21, 2017
Contributor
fergaloy
left a comment
fergaloy
left a comment
There was a problem hiding this comment.
Unfortunately, this does not fix the problem. It behaves the same way as before, deleting subscriptions that are in tabs that have not been visited.
alexandraohlson
force-pushed
the
master
branch
from
fc7491c to
36cdc03
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
The UpdateSubscriptions() function was considering a subsciption with
missing status parameter as a 'subscription to update to unset'.
It mainly because the getTriBoxValue function return the same thing
whether the value of the parameter is 'null' or 'unset'.
Therefore, this fix simply make sure the parameter wasn't 'null' before
updating the subscription.
Types of changes
Checklist
Further comments
This hasn't been tested at all.