Closed
Conversation
brh28
approved these changes
Jul 16, 2025
Collaborator
brh28
left a comment
brh28
left a comment
There was a problem hiding this comment.
Few comments, but nothing critical
Collaborator
There was a problem hiding this comment.
Non-blocking but I imagine it would be more convenient to have a package.json as a file next to the whitelist.js, but if it works I'm fine with it
| input: { npub: npub }, | ||
| }; | ||
|
|
||
| console.error( |
Contributor
Author
There was a problem hiding this comment.
the strfry program looks for stdout messages, error becoems the only way to log to be able to see it while debugging, can send it to opentelemetry though
| console.error("API response:", response.data); // Log response to stderr | ||
| return response.data.data.isFlashNpub.isFlashNpub; | ||
| } catch (error) { | ||
| console.error("Error fetching whitelist status:", error.message); |
Collaborator
There was a problem hiding this comment.
Ideally we should add open-telemetry traces
| - name: package-json | ||
| mountPath: /app/package.json | ||
| subPath: package.json | ||
| resources: |
Collaborator
There was a problem hiding this comment.
this seems fairly small. Not sure the load we're expecting here, but may be useful to either increase the limit or monitor resource usage
Contributor
Author
|
closing in favor of #139 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.