Conversation
motorina0
approved these changes
Jan 12, 2026
Contributor
|
We MUST ship this with additional docs. Else the new "domain" field will cause upcoming confusion and errors. Nginx config & Caddyfile config we need to provide in docs. |
DoktorShift
approved these changes
Jan 12, 2026
bdf5920 to
ce8d613
Compare
santyr
pushed a commit
to santyr/lnurlp
that referenced
this pull request
Jan 30, 2026
* feat: add optional domain field closes lnbits#119
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #119
closes #5
adds an optional domain field and uses it for lnurl if set, else it falls back to current host like we had.
redirect required for static urls, example nginx redirect. now you can run your lnbits on
https://test.b1tco1n.orgbut have a lightning address onb1tco1n.organd still run something else onhttps://b1tco1n.org/you could also run multiple domains on lnbits and have different domains for different links.