Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Branched off #8 at 1766ee4
The last of those commits was essential to making it build locally (thus passing prepush checks), prior to that I'd tried to supply openblas-src with build-deps, it must be a real dep but activated by cfg (I used build.rs to supply the openblas_src previously)
Here I make the openblas-src dep optional and use a default feature to activate it.
What happens now is I've told it to use openblas-src, ...and I expected it to pass the features but it doesn't. Maybe I still need to un-gate that local-build feature too