Open
Conversation
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For reference:
extern crate blas;andextern crate openblas_src;around the repo to ensure it would be "explicitly linked" against BLAS (and not say that there were undefined symbols likecblas_dgemvetcThis PR tries to swap the first branch for the 2nd one. I have low expectations as I already observed this led to 2 hours+ waiting for the i686 build (that was 6 mins using the 1st branch). Some sort of severe regression that is either an endless build for some unknown/unknowable reason (there are no logs being emitted), which can happen in compilation, or the openblas-src is somehow building from source rather than using the system libs. I don't see why this should happen but I don't know.