[example] Simplifying ingress sharding and using sharding propagation#57
Open
[example] Simplifying ingress sharding and using sharding propagation#57
Conversation
There was a problem hiding this comment.
Pull request overview
Updates the mlp-mpi example to reduce manual sharding annotations by relying on sharding propagation during lowering, and simplifies host-side gather logic used for reference checking.
Changes:
- Simplifies the MLIR payload by removing several explicit intermediate shard annotations and reusing a shared sharding for matmul ingress/egress.
- Adds a
sharding-propagationpass to the transform schedule (with optional IR printing when verbose). - Refactors repeated gather calls in Python into a
_gatherhelper and uses it for reference computation and correctness checks.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| examples/mlp-mpi/mlp_weight_stationary.mlir | Removes several explicit shard annotations and adjusts result sharding to rely more on propagation. |
| examples/mlp-mpi/mlp-mpi.py | Introduces _gather, updates reference/correctness paths to use it, and adds sharding-propagation to the schedule. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using the sharding propagation pass in the mlp-mpi example. This allows simpler ingress IR, because not all operands and results require annotation.
Also letting the payload return a result that is sharded like the activations, since that's what a real MLP would need (the result is the input for next layer).
This requires llvm/llvm-project#183028