[examples/mlp-mpi] Correcting/simplifying mlp-mpi readme#55
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR simplifies and corrects the README documentation for the mlp-mpi example, making it easier for users to run the MPI-based MLP example by adopting the project's standardized uv package manager approach.
Changes:
- Clarified and simplified the prerequisites section, removing confusing language about MPI implementations
- Replaced manual environment setup with
uv syncfor dependency management - Corrected the MPI library path from
$MPI_DIR/libmpi.soto$MPI_DIR/lib/libmpi.so(aligns with actual test commands in the code) - Removed obsolete environment variables (MLIR_DIR, LH_DIR) and parameters (--utils_dir, -s) from the example command
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.