Skip to content

Conversation

@YOzaz
Copy link

@YOzaz YOzaz commented Feb 17, 2017

Hi, few updates here:

  • Correct action to hook into
  • Missing username and password fields
  • Missing anchor (fragment) fields
  • Query string may be empty

@particthistle
Copy link

Having just looked at PR #3, @YOzaz suggestions also value add to the code up more.

Looking at #3 and then #5, on line 15, the $code variable in the function is not used, so this could also be removed in your PR @YOzaz, or @llonchj can you advise if it's actually necessary?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants