Skip to content

Conversation

@denvir-py
Copy link
Collaborator

@denvir-py denvir-py commented Sep 9, 2025

The CI/CD workflow began failing for MacOS due the way cmake was being installed. Calling brew install cmake forced Homebrew to resolve from homebrew/core, which clashed with the pinned one and aborted the job.

Another bug was found after solving the homebrew error that was not present until 2 weeks ago. This bug required permissions to git clone the repository. Line 46 solves this: persist-credentials: false

This PR will resolve the failing CI/CD.

@codecov-commenter
Copy link

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 64.34%. Comparing base (9835bc4) to head (bc6217a).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #108      +/-   ##
==========================================
+ Coverage   64.13%   64.34%   +0.21%     
==========================================
  Files          19       19              
  Lines        7028     7028              
==========================================
+ Hits         4507     4522      +15     
+ Misses       2521     2506      -15     
Flag Coverage Δ
unittests 64.34% <ø> (+0.21%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.
see 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@SuperdoerTrav
Copy link
Collaborator

Thanks for the detailed explanation and thorough fix, @denvir-py. The changes address the CI/CD failures cleanly, and the adjustments for Homebrew and credential handling look solid. All checks are passing, and Codecov confirms test coverage is maintained.

@SuperdoerTrav SuperdoerTrav merged commit a4bead9 into llnl:main Sep 9, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants