-
Notifications
You must be signed in to change notification settings - Fork 13
Fixing CI/CD flow #108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixing CI/CD flow #108
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #108 +/- ##
==========================================
+ Coverage 64.13% 64.34% +0.21%
==========================================
Files 19 19
Lines 7028 7028
==========================================
+ Hits 4507 4522 +15
+ Misses 2521 2506 -15
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
|
Thanks for the detailed explanation and thorough fix, @denvir-py. The changes address the CI/CD failures cleanly, and the adjustments for Homebrew and credential handling look solid. All checks are passing, and Codecov confirms test coverage is maintained. |
The CI/CD workflow began failing for MacOS due the way cmake was being installed. Calling
brew install cmakeforced Homebrew to resolve fromhomebrew/core, which clashed with the pinned one and aborted the job.Another bug was found after solving the homebrew error that was not present until 2 weeks ago. This bug required permissions to git clone the repository. Line 46 solves this:
persist-credentials: falseThis PR will resolve the failing CI/CD.