Fix method -increaseRef on PhxSocket, add tests#7
Open
gskbyte wants to merge 11 commits intolivehelpnow:masterfrom
Open
Fix method -increaseRef on PhxSocket, add tests#7gskbyte wants to merge 11 commits intolivehelpnow:masterfrom
gskbyte wants to merge 11 commits intolivehelpnow:masterfrom
Conversation
This reverts commit 6030cfb.
Modernize Objective-C code
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR basically fixes the implementation of the method
-increaseRefby effectively generating a different string every time it's called.This PR also adds support for tests the following way:
Podfileto add an example application target and a testing target. This fixes the fact that thePhoenixClient.xcworkspacewas empty, now it can be opened for the example project..gitignoredoesn't omit the Pods directory, we have to include the changes relative to updating SocketRocket to a newer version (a version 0.3.x was never released, it jumps to the 0.4)The actual changes are in the files
Classes/PhxSocket.mandExample/ChannelDemo/ChannelDemoTests/PhxSocketTests.m. Changes on all other files are provoked by changes onExample/ChannelDemo/Podfileand then executingpod install