Modernize Objective-C code and enhance Swift compatibility#6
Open
gskbyte wants to merge 7 commits intolivehelpnow:masterfrom
Open
Modernize Objective-C code and enhance Swift compatibility#6gskbyte wants to merge 7 commits intolivehelpnow:masterfrom
gskbyte wants to merge 7 commits intolivehelpnow:masterfrom
Conversation
added 7 commits
February 22, 2016 11:42
This reverts commit 6030cfb.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We are using the
PhoenixClientlibrary for a project in our company (https://github.com/xing) and we would like to collaborate with its development. We would like to fix some minor bugs and improve error handling a little bit.This is our first pull request, which doesn't do anything fancy, it just tries to improve compatibility with Swift:
retainwithstrong