-
Notifications
You must be signed in to change notification settings - Fork 796
fix: solves #5336 #5348
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Pratham1812
wants to merge
7
commits into
litmuschaos:master
Choose a base branch
from
Pratham1812:feat/vuln
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
fix: solves #5336 #5348
+284
−276
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…uschaos#5331) Signed-off-by: Shubham Chaudhary <shubham.chaudhary@harness.io> Signed-off-by: Pratham Agarwal <agarwalpratham1812@gmail.com>
Signed-off-by: Pratham Agarwal <agarwalpratham1812@gmail.com>
0425f04 to
6fd77c6
Compare
Contributor
|
Hi @Pratham1812, have you tried building the code after these changes? Please cross check if there are any breaking changes with the package upgrades |
Contributor
|
Hey @Pratham1812 Any updates on this? |
Signed-off-by: Pratham Agarwal <agarwalpratham1812@gmail.com>
Signed-off-by: Pratham Agarwal <agarwalpratham1812@gmail.com>
Author
|
Hey @PriteshKiri and @SarthakJain26 have upgraded the dependencies and also fixed all the failing tests in the repo. |
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.

Proposed changes
Solves #5336
Types of changes
What types of changes does your code introduce to Litmus? Put an
xin the boxes that applyChecklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.Dependency
Special notes for your reviewer:
All the packages with critical vulnerabilities have been upgraded.
It was tested by running
trivy fs . --severity HIGH,CRITICAL