fix(portal): persist projectID to prevent blank screen on refresh #5228

harshneyy · 2025-10-17T12:48:19Z

This PR fixes issue #5224.

Problem

On a fresh login, refreshing the page after navigating to a new tab (like "Environments") results in a blank screen. This is caused by the projectID not being persisted to localStorage because the utility function incorrectly treats an empty string as a falsy value.

Solution

I have updated the setUserDetails function in userDetails.ts to explicitly check for null or undefined. This ensures that a projectID (even if it's an empty string) is correctly saved to localStorage, preventing the redirect on page refresh.

Screenshots

Before Fix (Blank Screen on Refresh):

After Fix (Page Renders Correctly on Refresh):

Proposed changes

My PR fixes the blank screen issue by updating the setUserDetails utility function to correctly persist the projectID to localStorage

Types of changes

What types of changes does your code introduce to Litmus? Put an x in the boxes that apply

New feature (non-breaking change which adds functionality)
[ x] Bugfix (non-breaking change which fixes an issue)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
Documentation Update (if none of the other choices applies)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

[ x] I have read the CONTRIBUTING doc
[ x] I have signed the commit for DCO to be passed.
Lint and unit tests pass locally with my changes
I have added tests that prove my fix is effective or that my feature works (if appropriate)
I have added necessary documentation (if appropriate)

Dependency

Please add the links to the dependent PR need to be merged before this (if any).

Special notes for your reviewer:

harshneyy · 2025-10-23T17:10:58Z

Hi maintainers (@PriteshKiri, @SahilKr24, @amityt),

I'm having trouble getting the frontend-checks CI job to pass and could use some guidance.

My local environment uses Node v20, and yarn install completes successfully. I initially pushed changes generated with this setup.

The frontend-checks failed. Looking at the CI logs for that job, it seems to be using Node v16 (as specified in .github/workflows/push.yml).

When I switched my local environment to Node v16 and tried a clean yarn install, it failed because the pretty-format dependency requires Node >=18.

Since yarn install doesn't work locally with Node 16 but does with Node 20, I've switched back to Node 20, performed a clean install, and pushed the resulting yarn.lock.

Could the Node version specified (node-version: 16) in the push.yml workflow for frontend-checks be outdated compared to the project's current dependencies, which seem to require Node 18+? Any advice on how to proceed would be appreciated! Thanks.

harshneyy · 2025-10-30T23:11:28Z

Hi maintainers (@SarthakJain26
, @SahilKr24, @amityt),

I've pushed an update that fixes the frontend-checks (linting) error and updates the build.yml Node.js version (as the dependencies require Node 18+).

The CI is now failing at the web-unit-tests step with a large number of TypeScript errors (like TS2322: Property 'size' does not exist on type 'IconProps'). This seems to be a project-wide issue caused by the @harnessio/icons component's props changing.

Since this seems like a larger, separate refactoring task, I've reverted all my attempts to fix those unit test errors. My branch now only contains the original bug fix, the CI/lint fixes, and the yarn.lock file generated with Node 20.

Could you please advise on how to proceed? Thank you!

PriteshKiri · 2025-10-31T05:59:17Z

Hey @harshneyy

The team is currently working on fixing the build pipeline. We’ll keep this PR on hold for now and update you once it’s resolved.

PriteshKiri · 2025-11-27T18:00:10Z

Hey @harshneyy

Could you please resolve the conflicts?

PriteshKiri · 2025-12-11T11:41:04Z

Hey @harshneyy

Are you still working on this issue?

harshneyy · 2025-12-11T11:43:50Z

@PriteshKiri ...oh sorry I was busy these days with placements....i will try to finish this issue by end of the day or by tomorrow for sure

harshneyy · 2025-12-11T17:53:21Z

I mentioned in pr that I faced some difficulties while working on this....so i asked like how to proceed further.....so anyone could tell me how to proceed I may try it again
@PriteshKiri

PriteshKiri · 2025-12-12T08:36:39Z

Sure @amitbhatt818 @SarthakJain26 could you please look into this?

PriteshKiri · 2025-12-12T08:36:59Z

Meanwhile @harshneyy could you please resolve the conflicts?

harshneyy · 2025-12-12T09:04:44Z

I think i have already done that..but i was facing difficulty in passing the checks then ,I reached out in slack as well that time but i got no response till now > Meanwhile @harshneyy could you please resolve the conflicts?

harshneyy · 2025-12-12T09:04:47Z

I think i have already done that..but i was facing difficulty in passing the checks then ,I reached out in slack as well that time but i got no response till now > Meanwhile @harshneyy could you please resolve the conflicts?

amityt

I see that few changes were not required as the part of this PR. The main logic is there in the userDetails.ts files. @harshneyy Can you please update the changes or rebase with the master branch properly. Thank You!

amityt · 2025-12-12T10:15:05Z

.github/workflows/build.yml

      - uses: actions/setup-node@v4
        with:
-          node-version: 16
+          node-version: 20


Hi @harshneyy why is this version upgrade needed?

Hi @harshneyy why is this version upgrade needed?

I updated this because the CI frontend-checks were failing on Node 16. The project dependencies (specifically packages like pretty-format) seem to require Node 18+ now. yarn install was failing during the build. However, if the team has fixed the pipeline separately, I will revert this change to keep the PR focused.

amityt · 2025-12-12T10:15:37Z

.github/workflows/build.yml

       - uses: actions/setup-node@v4
         with:
-           node-version: 16
+           node-version: 20


amityt · 2025-12-12T10:16:19Z

chaoscenter/web/config/webpack.dev.js

+  '/api': {
+    pathRewrite: { '^/api': '' },
+    target: process.env.CHAOS_MANAGER
+      ? process.env.CHAOS_MANAGER
+      : targetLocalHost
+      ? 'http://localhost:8080'
+      : `${baseUrl}/api`,
+    secure: false,
+    changeOrigin: true,
+    logLevel: 'info'
+  },
+  '/auth': {
+    pathRewrite: { '^/auth': '' },
+    target: process.env.CHAOS_MANAGER
+      ? process.env.CHAOS_MANAGER
+      : targetLocalHost
+      ? 'http://localhost:3000'
+      : `${baseUrl}/auth`,
+    secure: false,
+    changeOrigin: true,
+    logLevel: 'info'
+  }
+}


This is just formatting change. Can you update the prettiers with the UI configuration?

This is just formatting change. Can you update the prettiers with the UI configuration?

Apologies, this was an unintended change caused by my local Prettier configuration. I will revert this file completely to match master

harshneyy · 2025-12-12T14:50:12Z

I see that few changes were not required as the part of this PR. The main logic is there in the userDetails.ts files. @harshneyy Can you please update the changes or rebase with the master branch properly. Thank You!

Hi @amityt, thanks for the review! You are right—the core logic is only in userDetails.ts. The other changes (Node version and formatting) happened because I was trying to get the CI pipeline to pass, as yarn install was failing on the older Node version. I will clean up the PR, revert the unnecessary files, and rebase immediately

Signed-off-by: Harshit Verma <harshitverma576@gmail.com>

harshneyy · 2025-12-12T15:33:09Z

Hi @amityt,

I have successfully cleaned up the PR.

I reverted the changes to webpack.dev.js and build.yml as requested.

The PR now contains only the logic fix in userDetails.ts.

Please note: The CI checks might fail again because I removed the Node.js version upgrade (v16 -> v20) from build.yml. It seems the project dependencies require a newer Node version to install correctly.

Ready for your review!

PriteshKiri requested review from SahilKr24 and amityt October 22, 2025 12:40

harshneyy force-pushed the fix/portal-blank-page-5224 branch 3 times, most recently from caa2e59 to 10d43c7 Compare October 23, 2025 16:32

PriteshKiri requested a review from SarthakJain26 October 24, 2025 09:07

harshneyy force-pushed the fix/portal-blank-page-5224 branch 5 times, most recently from 3a9a514 to 0cd79b9 Compare October 30, 2025 23:07

amityt requested changes Dec 12, 2025

View reviewed changes

harshneyy closed this Dec 12, 2025

harshneyy force-pushed the fix/portal-blank-page-5224 branch from 0cd79b9 to 82bb460 Compare December 12, 2025 14:59

fix(portal): persist projectID to prevent blank screen on refresh

953dba7

Signed-off-by: Harshit Verma <harshitverma576@gmail.com>

harshneyy reopened this Dec 12, 2025

fix(portal): persist projectID to prevent blank screen on refresh

61059f0

Signed-off-by: Harshit Verma <harshitverma576@gmail.com>

SarthakJain26 approved these changes Dec 15, 2025

View reviewed changes

fix(portal): persist projectID to prevent blank screen on refresh #5228

Are you sure you want to change the base?

fix(portal): persist projectID to prevent blank screen on refresh #5228

Uh oh!

Conversation

harshneyy commented Oct 17, 2025

Problem

Solution

Screenshots

Proposed changes

Types of changes

Checklist

Dependency

Special notes for your reviewer:

Uh oh!

harshneyy commented Oct 23, 2025

Uh oh!

harshneyy commented Oct 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

PriteshKiri commented Oct 31, 2025

Uh oh!

PriteshKiri commented Nov 27, 2025

Uh oh!

PriteshKiri commented Dec 11, 2025

Uh oh!

harshneyy commented Dec 11, 2025

Uh oh!

harshneyy commented Dec 11, 2025

Uh oh!

PriteshKiri commented Dec 12, 2025

Uh oh!

PriteshKiri commented Dec 12, 2025

Uh oh!

harshneyy commented Dec 12, 2025

Uh oh!

harshneyy commented Dec 12, 2025

Uh oh!

amityt left a comment

Choose a reason for hiding this comment

Uh oh!

amityt Dec 12, 2025

Choose a reason for hiding this comment

Uh oh!

harshneyy Dec 12, 2025

Choose a reason for hiding this comment

Uh oh!

amityt Dec 12, 2025

Choose a reason for hiding this comment

Uh oh!

amityt Dec 12, 2025

Choose a reason for hiding this comment

Uh oh!

harshneyy Dec 12, 2025

Choose a reason for hiding this comment

Uh oh!

harshneyy commented Dec 12, 2025

Uh oh!

harshneyy commented Dec 12, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

harshneyy commented Oct 30, 2025 •

edited

Loading