CRUXX-580 improve channel publisher by always copying the depth#79
Open
CRUXX-580 improve channel publisher by always copying the depth#79
Conversation
cmcnelis
reviewed
Jun 25, 2018
| " current_count = tonumber(current_count)\n" + | ||
| "end\n" + | ||
| "if current_count <= tonumber($lastSeenCount$) then\n" + | ||
| " return {tostring(current_count)}\n" + |
There was a problem hiding this comment.
What should the caller do in this scenario? Update lastSeen to the past?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The receiver interface did not have a way to return the depth of the channel on every call; it would return null or the input depth of the channel if the channel's depth did not exist or less than the input channel's depth. This fixes the interface and always returns the depth of the channel.