Add sample for oneline spanned ellipsizer #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… and `getSize`. If text is `android.text.Layout.SpannedEllipsizer`, `text ! = view.getText()` will be false and stop. So changed to stop processing when `spanned.getSpanStart(this) == -1`
takara727
requested changes
Sep 26, 2022
Contributor
takara727
left a comment
takara727
left a comment
There was a problem hiding this comment.
これだけの記述だと後でなんのためにあるかわからないかと思います。
なんのテストがわかりやすいように私だったら以下のようにするかと思います。
- テストの先頭に GifSpan Test と記載
EditTextのヒントにReplace $ with GIFと記載Single-LineとMulti-Lineというラベル(ラベル用のTextView)をつけたTextViewをそれぞれ用意(Multi-Line は行数制限なし)EditTextに文字が入力されたら即時にTextViewに反映。$のところだけ GifSpan をつける
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This sample is to check if Gif pictograms are displayed correctly in SpannedEllipsizer.