Fix infinite rebuild recursion in settings UI#50
Open
wancor1 wants to merge 1 commit intoliplum:masterfrom
Open
Fix infinite rebuild recursion in settings UI#50wancor1 wants to merge 1 commit intoliplum:masterfrom
wancor1 wants to merge 1 commit intoliplum:masterfrom
Conversation
Fix settings menu crash caused by infinite rebuild recursion SettingsTableX was able to call rebuild() recursively from multiple paths, resulting in StackOverflowError. Added rebuild guard and removed implicit rebuild triggers.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Probably fixes settings menu crash
SettingsTableX was recursively calling rebuild() and
crashing the settings menu.
Added a guard to stop infinite recursion.
Seems to work, but I might be missing something.