Skip to content

Conversation

@wangrong1069
Copy link
Contributor

No description provided.

@github-actions
Copy link

github-actions bot commented Aug 12, 2025

TAG Bot

TAG: 6.0.9
EXISTED: no
DISTRIBUTION: unstable

@wangrong1069 wangrong1069 force-pushed the pr0812 branch 2 times, most recently from 3d2a7f6 to 68a442d Compare August 12, 2025 13:30
- Modified build dependencies to support both Qt6 and Qt5.
- Implemented automatic detection of Qt version in the build rules.
- Set the -ffile-prefix-map compilation option to achieve reproducible builds

Log: update build configuration for Qt compatibility
As title.

Log: Update version to 6.0.9
@deepin-ci-robot
Copy link

deepin pr auto review

代码审查意见:

  1. Changelog 更新:

    • debian/changelog 文件中,新增了一个条目来记录对构建配置的更新。这是一个好的做法,因为它可以帮助维护者了解每次更改的目的。
  2. Control 文件更新:

    • debian/control 文件中,将 qt6-base-devqt6-base-dev-toolsqt6-base-private-dev 等依赖项替换为 qt6-base-dev | qt5-qmake 等形式。这可能是为了兼容性考虑,但需要确认是否有足够的测试来验证这种替换不会引入问题。
    • 同样,libdtk6gui-devlibdtk6widget-devqt6-tools-dev-toolsqt6-tools-devqt6-svg-dev 等依赖项也被替换为新的版本或替代品。这些更改也需要进行充分的测试。
  3. Rules 文件更新:

    • debian/rules 文件中,添加了 Qt 版本自动检测逻辑。这是一个好的实践,因为它可以确保构建系统能够根据环境自动选择合适的 Qt 版本。
    • 使用 command -v qmake6 来检测 qmake6 是否存在,这是一个有效的方法。
    • 如果未找到 qmake6,则回退到 qmake,并设置 QT_SELECT 为 5。这是一个合理的回退策略。
    • override_dh_auto_configure 目标中,添加了编译标志和链接标志,这有助于提高代码的调试和安全性。但是,需要确保这些标志不会与现有的构建配置冲突。

总体来说,这些更改都是为了提高代码的可维护性和兼容性。然而,需要确保这些更改已经过充分的测试,并且不会引入新的问题。

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: lzwind, wangrong1069

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@wangrong1069
Copy link
Contributor Author

/merge

@deepin-bot deepin-bot bot merged commit fd68fea into linuxdeepin:master Aug 13, 2025
15 checks passed
@wangrong1069 wangrong1069 deleted the pr0812 branch August 13, 2025 03:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants