Skip to content

feat: add search status label on findbar and replacebar #278

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
Fozei wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat: add search status label on findbar and replacebar #278

Fozei wants to merge 1 commit into from

Conversation

@Fozei
Copy link

@Fozei Fozei commented May 6, 2024

desc: 在查找和替换组件上,增加指示当前选中是第几个和总共有多少个查找结果的标签

@Fozei
feat: add search status label on findbar and replacebar
5106baf 
desc: 在查找和替换组件上,增加指示当前选中是第几个和总共有多少个查找结果的标签
@deepin-ci-robot
Copy link

deepin-ci-robot commented May 6, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Fozei

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@deepin-ci-robot
Copy link

deepin-ci-robot commented May 6, 2024

Hi @Fozei. Thanks for your PR.

I'm waiting for a linuxdeepin member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Fozei Fozei marked this pull request as ready for review May 6, 2024 05:02
@rb-union
Copy link
Contributor

rb-union commented Jul 3, 2024

很好的提交！不过对于大文本下使用遍历的方式有待商榷，有较明显的性能问题。

@deepin-bot
Copy link
Contributor

deepin-bot bot commented Jul 4, 2024

TAG Bot

New tag: 6.0.18
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #282

@Fozei
Copy link
Author

Fozei commented Jul 8, 2024

@rb-union Thank you for your reply！确实是这样，我在编码时也考虑到了这一层，但是受制于QT组件本身的限制和个人水平，暂时没有想到更好的办法。在编码时，我甚至参考了VS Code的源码，发现它在至多寻找到19999个出现次数时，就停止再往下查找了。我个人认为，目前我们的编辑器，在加载大文本时，也是有比较明显的性能问题的，所以还是硬着头皮提了这个PR ^_^。希望深度有机会的话，可以把我们的编辑器重构一把哈哈，做成编辑器届的瑞士军刀，小巧而好用，加油！Thanks again ！

@deepin-bot
Copy link
Contributor

deepin-bot bot commented Aug 21, 2024

TAG Bot

New tag: 6.5.0
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #286

@deepin-bot
Copy link
Contributor

deepin-bot bot commented Sep 3, 2024

TAG Bot

New tag: 6.5.1
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #289

@deepin-bot
Copy link
Contributor

deepin-bot bot commented Sep 13, 2024

TAG Bot

New tag: 6.5.2
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #291

@deepin-bot
Copy link
Contributor

deepin-bot bot commented Sep 27, 2024

TAG Bot

New tag: 6.5.3
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #294

@deepin-bot
Copy link
Contributor

deepin-bot bot commented Nov 7, 2024

TAG Bot

New tag: 6.5.4
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #296

@deepin-bot
Copy link
Contributor

deepin-bot bot commented Nov 30, 2024

TAG Bot

New tag: 6.5.5
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #300

@deepin-bot
Copy link
Contributor

deepin-bot bot commented Dec 2, 2024

TAG Bot

New tag: 6.5.6
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #301

@deepin-bot
Copy link
Contributor

deepin-bot bot commented Dec 14, 2024

TAG Bot

New tag: 6.5.7
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #306

@deepin-bot
Copy link
Contributor

deepin-bot bot commented Dec 20, 2024

TAG Bot

New tag: 6.5.8
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #307

@deepin-bot
Copy link
Contributor

deepin-bot bot commented Dec 26, 2024

TAG Bot

New tag: 6.5.9
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #314

@deepin-bot
Copy link
Contributor

deepin-bot bot commented Jan 2, 2025

TAG Bot

New tag: 6.5.10
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #316

@deepin-bot
Copy link
Contributor

deepin-bot bot commented Jan 9, 2025

TAG Bot

New tag: 6.5.11
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #318

@deepin-bot
Copy link
Contributor

deepin-bot bot commented Jan 16, 2025

TAG Bot

New tag: 6.5.12
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #322

@deepin-bot
Copy link
Contributor

deepin-bot bot commented Jan 20, 2025

TAG Bot

New tag: 6.5.13
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #324

@deepin-bot
Copy link
Contributor

deepin-bot bot commented Feb 14, 2025

TAG Bot

New tag: 6.5.14
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #326

@deepin-bot
Copy link
Contributor

deepin-bot bot commented Feb 20, 2025

TAG Bot

New tag: 6.5.15
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #329

@deepin-bot
Copy link
Contributor

deepin-bot bot commented Feb 27, 2025

TAG Bot

New tag: 6.5.16
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #330

@deepin-bot
Copy link
Contributor

deepin-bot bot commented Mar 12, 2025

TAG Bot

New tag: 6.5.17
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #334

@deepin-bot
Copy link
Contributor

deepin-bot bot commented Mar 20, 2025

TAG Bot

New tag: 6.5.18
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #335

@deepin-bot
Copy link
Contributor

deepin-bot bot commented Mar 28, 2025

TAG Bot

New tag: 6.5.19
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #339

@deepin-bot
Copy link
Contributor

deepin-bot bot commented Mar 28, 2025

TAG Bot

New tag: 6.5.20
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #341

@deepin-bot
Copy link
Contributor

deepin-bot bot commented Apr 2, 2025

TAG Bot

New tag: 6.5.21
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #344

@deepin-bot
Copy link
Contributor

deepin-bot bot commented Apr 10, 2025

TAG Bot

New tag: 6.5.22
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #346

@deepin-bot
Copy link
Contributor

deepin-bot bot commented Apr 16, 2025

TAG Bot

New tag: 6.5.23
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #347

@deepin-bot
Copy link
Contributor

deepin-bot bot commented Apr 24, 2025

TAG Bot

New tag: 6.5.24
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #352

@deepin-bot
Copy link
Contributor

deepin-bot bot commented May 14, 2025

TAG Bot

New tag: 6.5.25
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #353

@deepin-bot
Copy link
Contributor

deepin-bot bot commented Jun 18, 2025

TAG Bot

New tag: 6.5.26
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #359

@deepin-bot
Copy link
Contributor

deepin-bot bot commented Jun 23, 2025

TAG Bot

New tag: 6.5.27
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #362

@deepin-bot
Copy link
Contributor

deepin-bot bot commented Jul 2, 2025

TAG Bot

New tag: 6.5.28
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #368

@deepin-bot
Copy link
Contributor

deepin-bot bot commented Jul 10, 2025

TAG Bot

New tag: 6.5.29
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #370

@deepin-bot
Copy link
Contributor

deepin-bot bot commented Jul 10, 2025

TAG Bot

New tag: 6.5.30
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #372

@deepin-bot
Copy link
Contributor

deepin-bot bot commented Jul 16, 2025

TAG Bot

New tag: 6.5.31
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #373

@deepin-bot
Copy link
Contributor

deepin-bot bot commented Jul 18, 2025

TAG Bot

New tag: 6.5.32
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #374

@deepin-bot
Copy link
Contributor

deepin-bot bot commented Aug 7, 2025

TAG Bot

New tag: 6.5.33
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #376

@deepin-bot
Copy link
Contributor

deepin-bot bot commented Aug 13, 2025

TAG Bot

New tag: 6.5.34
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #379

@deepin-bot
Copy link
Contributor

deepin-bot bot commented Aug 22, 2025

TAG Bot

New tag: 6.5.35
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #380

@deepin-bot
Copy link
Contributor

deepin-bot bot commented Aug 27, 2025

TAG Bot

New tag: 6.5.36
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #383

@deepin-bot
Copy link
Contributor

deepin-bot bot commented Sep 4, 2025

TAG Bot

New tag: 6.5.37
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #386

@deepin-bot
Copy link
Contributor

deepin-bot bot commented Sep 17, 2025

TAG Bot

New tag: 6.5.38
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #387

@deepin-bot
Copy link
Contributor

deepin-bot bot commented Oct 16, 2025

TAG Bot

New tag: 6.5.39
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #393

@deepin-bot
Copy link
Contributor

deepin-bot bot commented Oct 30, 2025

TAG Bot

New tag: 6.5.40
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #396

@deepin-bot
Copy link
Contributor

deepin-bot bot commented Nov 6, 2025

TAG Bot

New tag: 6.5.41
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #398

@deepin-bot
Copy link
Contributor

deepin-bot bot commented Nov 20, 2025

TAG Bot

New tag: 6.5.42
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #402

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

needs-ok-to-test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Fozei @deepin-ci-robot @rb-union