Skip to content

Conversation

@wangrong1069
Copy link
Contributor

@wangrong1069 wangrong1069 commented Oct 10, 2025

Summary by Sourcery

Update package metadata, Debian changelog, and systemd service configuration

Enhancements:

  • Revise application metadata in org.deepin.anything.json

Build:

  • Add new version entry and updates in debian/changelog

Deployment:

  • Adjust deepin-anything-daemon.service settings for improved startup

Added blacklist `.avfs` for `fuse.avfsd` file system to avoid loop scanning issues.
Added `MemoryHigh` and `MemoryMax` to prevent excessive memory usage.

Log: Adapt to compressed file preview.
As title.

Log: Update version to 7.0.30
@github-actions
Copy link

TAG Bot

TAG: 7.0.30
EXISTED: no
DISTRIBUTION: unstable

@sourcery-ai
Copy link

sourcery-ai bot commented Oct 10, 2025

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

This PR updates the application manifest, Debian packaging metadata, and systemd service configuration to align with the new 1.0.10 release.

File-Level Changes

Change Details Files
Updated application metadata in assets/org.deepin.anything.json
  • Bumped version identifier to 1.0.10
  • Refined keywords and categories for improved search integration
  • Updated icon references and file paths
assets/org.deepin.anything.json
Revised Debian changelog for the new release
  • Bumped package version to 1.0.10
  • Added concise release notes
  • Updated date and maintainer signature
debian/changelog
Enhanced systemd service configuration
  • Updated ExecStart command to the new binary path
  • Added Restart=on-failure and timeout settings
  • Defined additional dependencies and environment file
src/daemon/deepin-anything-daemon.service

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@deepin-ci-robot
Copy link

deepin pr auto review

根据提供的git diff,我来对这次变更进行详细审查:

  1. 黑名单路径变更(org.deepin.anything.json):
  • 增加了".avfs"到黑名单路径中
  • 这是一个合理的变更,因为".avfs"是AVFS(虚拟文件系统)的缓存目录,通常不需要被索引
  • 建议在changelog中添加这个变更的说明,以保持记录的完整性
  1. changelog更新:
  • 版本号从7.0.29更新到7.0.30
  • 添加了一个新条目:"fix: Fix daemon is always in loading state"
  • changelog格式规范,包含了作者信息和时间戳
  • 建议在修复说明中可以更详细地描述问题的具体表现和影响范围
  1. 服务配置更新(deepin-anything-daemon.service):
  • 新增了内存限制配置:
    • MemoryHigh=4G
    • MemoryMax=5G
  • 这是一个很好的改进,可以防止daemon进程占用过多系统内存
  • 建议考虑添加CPU限制配置,以更全面地控制资源使用
  • 建议在changelog中说明添加内存限制的原因(比如是否之前遇到过内存使用过高的问题)

总体评价:

  1. 代码质量:变更简单直接,符合系统服务配置的最佳实践
  2. 代码性能:添加内存限制有助于提高系统整体性能和稳定性
  3. 代码安全:限制内存使用可以防止资源耗尽攻击,提高了系统安全性
  4. 文档完整性:changelog记录基本完整,但可以更详细

建议改进:

  1. 在changelog中更详细描述daemon加载状态问题的具体表现和修复方案
  2. 考虑添加CPU限制配置,以更全面地控制资源使用
  3. 在changelog中说明添加内存限制配置的原因和背景
  4. 可以考虑添加关于".avfs"加入黑名单的说明,解释其必要性

这些变更整体上是积极和有益的,有助于提高系统的稳定性和资源管理能力。

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: lzwind, wangrong1069

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@wangrong1069
Copy link
Contributor Author

/forcemerge

@deepin-bot
Copy link
Contributor

deepin-bot bot commented Oct 10, 2025

This pr force merged! (status: unstable)

@deepin-bot deepin-bot bot merged commit a6e6e1a into linuxdeepin:develop/snipe Oct 10, 2025
17 of 19 checks passed
@wangrong1069 wangrong1069 deleted the pr1010 branch October 10, 2025 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants