Skip to content

Conversation

@yixinshark
Copy link
Contributor

@yixinshark yixinshark commented Jan 14, 2026

update changelog to 2.0.26

Summary by Sourcery

Chores:

  • Refresh the Debian changelog entry to reflect version 2.0.26.

update changelog to 2.0.26
@github-actions
Copy link

TAG Bot

TAG: 2.0.26
EXISTED: no
DISTRIBUTION: unstable

@sourcery-ai
Copy link

sourcery-ai bot commented Jan 14, 2026

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Bumps the Debian package version to 2.0.26 by updating the changelog entry.

File-Level Changes

Change Details Files
Update Debian changelog to reflect new 2.0.26 release.
  • Adjust the top changelog entry to use version 2.0.26.
  • Ensure the changelog format remains compliant with Debian packaging standards.
debian/changelog

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@deepin-ci-robot
Copy link

deepin pr auto review

这段 debian/changelog 的 diff 内容主要记录了软件包 dde-shell 的版本更新日志。以下是对该 diff 的审查意见,主要关注格式规范、逻辑和潜在问题:

1. 格式与规范审查

  • 符合 Debian 标准:该 changelog 条目严格遵循了 Debian 的 debchange 格式规范。
    • 格式:package (version) distribution; urgency=urgency
    • 维护者信息:-- maintainer-name <email-address> date
    • 缩进:变更条目使用了一个 tab 和两个空格的缩进( *),这是标准做法。
  • 日期格式:日期使用了标准的 RFC 5322 格式,且包含了时区信息 (+0800),格式正确。

2. 逻辑与内容审查

  • 版本号递增:版本号从 2.0.25 升级到了 2.0.26,符合语义化版本控制(补丁版本递增),因为这次的改动主要是修复和翻译更新。
  • 变更条目清晰
    • fix: update safeCommands whitelist for notification service:明确指出了是对通知服务的安全命令白名单的更新。这通常是为了修复安全漏洞或允许新的必要操作。
    • i18n: Updates for project Deepin Desktop Environment (#1381):指出了是国际化(翻译)更新,并关联了 Issue 编号,便于追踪。
  • 紧急程度urgency=medium 设置合理。虽然包含安全白名单的更新,但这通常属于常规修复或增强,除非是紧急的 CVE 修复,否则 medium 是恰当的。

3. 潜在问题与改进建议

  • 日期年份异常
    • 问题:日期显示为 Wed, 14 Jan 2026
    • 建议:这看起来像是一个未来的日期(除非这是为了测试或时间旅行)。请确认这是否为笔误,实际年份应为 2025 或更早。如果是笔误,必须修正,否则打包工具可能会发出警告或导致时间线混乱。
  • 变更粒度
    • 观察:目前将 "fix"(修复)和 "i18n"(翻译)合并在同一个版本发布中。
    • 建议:如果 "safeCommands" 的更新非常关键(例如涉及严重的安全漏洞),建议将其单独作为一个版本发布,或者将 urgency 调整为 highcritical。如果只是常规维护,目前的合并方式是可以接受的,有助于减少版本碎片化。

总结

这段代码在格式和语法上没有问题,符合 Debian 打包规范。主要需要关注的是日期年份的正确性。除此之外,变更记录清晰,维护良好。

修正后的建议(假设日期年份有误):

+ -- zhaoyingzhen <zhaoyingzhen@uniontech.com>  Wed, 14 Jan 2025 14:50:15 +0800

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: robertkill, yixinshark

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@yixinshark
Copy link
Contributor Author

/forcemerge

@deepin-bot
Copy link

deepin-bot bot commented Jan 14, 2026

This pr force merged! (status: blocked)

@deepin-bot deepin-bot bot merged commit 61a07ee into linuxdeepin:master Jan 14, 2026
9 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants